Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nanodrop eight support #230

Merged
merged 13 commits into from
Jan 19, 2024
Merged

Nanodrop eight support #230

merged 13 commits into from
Jan 19, 2024

Conversation

bwolfe-benchling
Copy link
Collaborator

Provide support for Nanodrop Eight

@bwolfe-benchling bwolfe-benchling requested a review from a team as a code owner January 11, 2024 20:12
@bwolfe-benchling bwolfe-benchling requested review from mdlu and removed request for a team January 11, 2024 20:12
@bdworth bdworth requested review from bdworth and removed request for mdlu January 11, 2024 20:14
@bwolfe-benchling
Merge branch 'main' into nanodrop-eight-support
ec04e46 
Signed-off-by: Ben Wolfe <82657751+bwolfe-benchling@users.noreply.github.com>
bdworth
bdworth suggested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@bdworth bdworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not finished reviewing yet, but some initial comments

src/allotropy/parsers/thermo_fisher_nanodrop_eight/nanodrop_eight_parser.py Outdated Show resolved Hide resolved
src/allotropy/parsers/thermo_fisher_nanodrop_eight/nanodrop_eight_parser.py Outdated Show resolved Hide resolved
src/allotropy/parsers/thermo_fisher_nanodrop_eight/nanodrop_eight_parser.py Show resolved Hide resolved
src/allotropy/parsers/thermo_fisher_nanodrop_eight/nanodrop_eight_parser.py Outdated Show resolved Hide resolved
src/allotropy/parsers/thermo_fisher_nanodrop_eight/nanodrop_eight_parser.py Outdated Show resolved Hide resolved
bdworth
bdworth previously requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@bdworth bdworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more comments

src/allotropy/parsers/thermo_fisher_nanodrop_eight/nanodrop_eight_reader.py Show resolved Hide resolved
src/allotropy/parsers/thermo_fisher_nanodrop_eight/nanodrop_eight_parser.py Outdated Show resolved Hide resolved
bwolfe-benchling and others added 5 commits January 12, 2024 12:05
@bwolfe-benchling
Merge branch 'main' into nanodrop-eight-support
948275e 
Signed-off-by: Ben Wolfe <82657751+bwolfe-benchling@users.noreply.github.com>
@bwolfe-benchling
refactor get_str
03d16aa
@bwolfe-benchling
use UNITLESS const
cb456a5
@bwolfe-benchling
refactor typing for _get_concentration
ea6e416
@bwolfe-benchling
Merge branch 'main' into nanodrop-eight-support
a30045b 
Signed-off-by: Ben Wolfe <82657751+bwolfe-benchling@users.noreply.github.com>
@nathan-stender nathan-stender merged commit 4933c29 into Benchling-Open-Source:main Jan 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdworth bdworth bdworth left review comments

@nathan-stender nathan-stender nathan-stender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwolfe-benchling @bdworth @nathan-stender